Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undead Population and Scourge Invite Conversion #1238

Closed
wants to merge 8 commits into from

Conversation

edmund-h
Copy link
Contributor

Changelog:

  • Undead heritage cultures now will start the game with an 80% chance to have the Undead trait
  • Inviting to court, recruiting guests, and granting titles now has a 90% chance to turn the recruit and their accompanying family Undead.

Developer changelog:

  • Added encapsulated conversion and population constant(?) values to common/script_values/wc_plague_values.txt
  • Added Undead population generation mechanic to common/scripted_effects/wc_race_effects.txt
  • Added conversion for recruitment interactions to common/character_interactions/00_courtier_and_guest_interactions.txt
  • Added conversion for title grants to common/character_interactions/00_grant_titles_interaction.txt
  • Added localization to localization/english/wc_tooltip_l_english.yml

Tests:

  • There are no errors in wc files in Documents\Paradox Interactive\Crusader Kings III\logs\error.log except portrait_decals.cpp:101
  • The mod takes less than 5.5 GB in the Task Manager (Windows)

How to test:

  • Begin a new game in the 603 or 605 bookmark as a Scourge character
  • Inspect "Damned", "Forsaken", and other Undead heritage culture characters for a majority Undead population

Known issues:

  • Children do not seem to get the Undead trait at game start.
  • Player is not informed that character will get the Undead trait in the Character Generator.

@edmund-h edmund-h added localisation 📄 This issue or pull request supposes localization changes good first testing 🧪 A good and easy PR to start testing with cultural 🎓 Involves cultural mechanics racial:fish: Involves racial mechanics new feature ⭐ Involves adding new feature that affects game and removed new feature ⭐ Involves adding new feature that affects game labels Nov 16, 2023
@edmund-h edmund-h closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cultural 🎓 Involves cultural mechanics good first testing 🧪 A good and easy PR to start testing with localisation 📄 This issue or pull request supposes localization changes racial:fish: Involves racial mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant